The Scottish artist’s love of the Highlands is plain to see in many of the works on display at the City Art Centre in Edinburgh